From fbacc7c765f7ad329c4eed66e50669309f139ab8 Mon Sep 17 00:00:00 2001
From: mrT23 <tal.r@codium.ai>
Date: Mon, 13 May 2024 09:19:08 +0300
Subject: [PATCH] artifact

---
 docs/docs/tools/improve.md            | 4 ++++
 pr_agent/settings/configuration.toml  | 2 ++
 pr_agent/tools/pr_code_suggestions.py | 8 +++++---
 3 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/docs/docs/tools/improve.md b/docs/docs/tools/improve.md
index e8b4dd6f..7906f426 100644
--- a/docs/docs/tools/improve.md
+++ b/docs/docs/tools/improve.md
@@ -90,6 +90,10 @@ Hence, the total number of suggestions is proportional to the number of chunks,
     <td><b>self_reflect_on_suggestions</b></td>
     <td>If set to true, the improve tool will calculate an importance score for each suggestion [1-10], and sort the suggestion labels group based on this score. Default is true.</td>
   </tr>
+  <tr>
+    <td><b>suggestions_score_threshold</b></td>
+    <td> Any suggestion with importance score less than this threshold will be removed. Default is 0. Highly recommend not to set this value above 7-8, since above it may clip relevant suggestions that can be useful. </td>
+  </tr>
   <tr>
     <td><b>enable_help_text</b></td>
     <td>If set to true, the tool will display a help text in the comment. Default is true.</td>
diff --git a/pr_agent/settings/configuration.toml b/pr_agent/settings/configuration.toml
index c1d0dded..b84bce61 100644
--- a/pr_agent/settings/configuration.toml
+++ b/pr_agent/settings/configuration.toml
@@ -85,7 +85,9 @@ extra_instructions = ""
 rank_suggestions = false
 enable_help_text=false
 persistent_comment=false
+# suggestions scoring
 self_reflect_on_suggestions=true
+suggestions_score_threshold=0 # [0-10]. highly recommend not to set this value above 8, since above it may clip highly relevant suggestions
 # params for '/improve --extended' mode
 auto_extended_mode=true
 num_code_suggestions_per_chunk=4
diff --git a/pr_agent/tools/pr_code_suggestions.py b/pr_agent/tools/pr_code_suggestions.py
index a192e80d..8ea9b595 100644
--- a/pr_agent/tools/pr_code_suggestions.py
+++ b/pr_agent/tools/pr_code_suggestions.py
@@ -344,14 +344,15 @@ class PRCodeSuggestions:
             data = {"code_suggestions": []}
             for i, predictions in enumerate(prediction_list):
                 if "code_suggestions" in predictions:
+                    score_threshold = max(1,get_settings().pr_code_suggestions.suggestions_score_threshold)
                     for prediction in predictions["code_suggestions"]:
                         try:
                             if get_settings().pr_code_suggestions.self_reflect_on_suggestions:
                                 score = int(prediction["score"])
-                                if score > 0:
+                                if score >= score_threshold:
                                     data["code_suggestions"].append(prediction)
                                 else:
-                                    get_logger().info(f"Removing suggestions {i}, because score is {score}",
+                                    get_logger().info(f"Removing suggestions {i}, because score is {score}, and score_threshold is {score_threshold}",
                                                       artifact=prediction)
                             else:
                                 get_logger().error(f"Error getting PR diff, no code suggestions found in call {i + 1}")
@@ -517,11 +518,12 @@ class PRCodeSuggestions:
                         pr_body += f"Why: {suggestion['score_why']}\n\n"
                         pr_body += f"</details>"
 
+                    pr_body += f"</details>"
+
                     # # add another column for 'score'
                     if get_settings().pr_code_suggestions.self_reflect_on_suggestions:
                         pr_body += f"</td><td align=center>{suggestion['score']}\n\n"
 
-                    pr_body += f"</details>"
                     pr_body += f"</td></tr>"