From e6548f4fe1b06a75848748d9809195a9b371afe7 Mon Sep 17 00:00:00 2001 From: mrT23 Date: Sun, 8 Oct 2023 16:57:22 +0300 Subject: [PATCH] simpler solution --- pr_agent/git_providers/gitlab_provider.py | 5 +---- pr_agent/tools/pr_code_suggestions.py | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/pr_agent/git_providers/gitlab_provider.py b/pr_agent/git_providers/gitlab_provider.py index de3762e6..ae2d621f 100644 --- a/pr_agent/git_providers/gitlab_provider.py +++ b/pr_agent/git_providers/gitlab_provider.py @@ -196,10 +196,6 @@ class GitLabProvider(GitProvider): return self.last_diff # fallback to last_diff if no relevant diff is found def publish_code_suggestions(self, code_suggestions: list) -> bool: - if len(code_suggestions) > 1: - logging.debug(f"in gitlab we dont currently support publishing multiple code suggestions simultaneously") - return False - for suggestion in code_suggestions: try: body = suggestion['body'] @@ -231,6 +227,7 @@ class GitLabProvider(GitProvider): target_file, target_line_no) except Exception as e: logging.exception(f"Could not publish code suggestion:\nsuggestion: {suggestion}\nerror: {e}") + return True def search_line(self, relevant_file, relevant_line_in_file): target_file = None diff --git a/pr_agent/tools/pr_code_suggestions.py b/pr_agent/tools/pr_code_suggestions.py index d49459b0..7f0b1264 100644 --- a/pr_agent/tools/pr_code_suggestions.py +++ b/pr_agent/tools/pr_code_suggestions.py @@ -140,7 +140,7 @@ class PRCodeSuggestions: is_successful = self.git_provider.publish_code_suggestions(code_suggestions) if not is_successful: - # logging.info("Failed to publish code suggestions, trying to publish each suggestion separately") + logging.info("Failed to publish code suggestions, trying to publish each suggestion separately") for code_suggestion in code_suggestions: self.git_provider.publish_code_suggestions([code_suggestion])