xiaxinhang/pr-agent
1
0
Fork 0
mirror of https://github.com/qodo-ai/pr-agent.git synced 2025-07-04 21:00:40 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1859 from alessio-locatelli/respect_publish_output_no_suggestions_by_reviewer

Browse Source 
feat: support 'publish_output_no_suggestions' by 'pr_reviewer'
This commit is contained in:
Tal
2025-06-13 19:42:32 +03:00
committed by GitHub
parent 9c17a3902b 3b42b0e152
commit de8913e905
2 changed files with 22 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
pr_agent/settings/configuration.toml
View File

@ -80,6 +80,7 @@ require_can_be_split_review=false
require_security_review=true require_security_review=true
require_ticket_analysis_review=true require_ticket_analysis_review=true
# general options # general options
publish_output_no_suggestions=true # Set to "false" if you only need the reviewer's remarks (not labels, not "security audit", etc.) and want to avoid noisy "No major issues detected" comments.
persistent_comment=true persistent_comment=true
extra_instructions = "" extra_instructions = ""
num_max_findings = 3 num_max_findings = 3

35
pr_agent/tools/pr_reviewer.py
View File

@ -158,25 +158,32 @@ class PRReviewer:
pr_review = self._prepare_pr_review() pr_review = self._prepare_pr_review()
get_logger().debug(f"PR output", artifact=pr_review) get_logger().debug(f"PR output", artifact=pr_review)
if get_settings().config.publish_output: should_publish = get_settings().config.publish_output and self._should_publish_review_no_suggestions(pr_review)
# publish the review if not should_publish:
if get_settings().pr_reviewer.persistent_comment and not self.incremental.is_incremental: reason = "Review output is not published"
final_update_message = get_settings().pr_reviewer.final_update_message if get_settings().config.publish_output:
self.git_provider.publish_persistent_comment(pr_review, reason += ": no major issues detected."
initial_header=f"{PRReviewHeader.REGULAR.value} 🔍", get_logger().info(reason)
update_header=True,
final_update_message=final_update_message, )
else:
self.git_provider.publish_comment(pr_review)
self.git_provider.remove_initial_comment()
else:
get_logger().info("Review output is not published")
get_settings().data = {"artifact": pr_review} get_settings().data = {"artifact": pr_review}
return return
# publish the review
if get_settings().pr_reviewer.persistent_comment and not self.incremental.is_incremental:
final_update_message = get_settings().pr_reviewer.final_update_message
self.git_provider.publish_persistent_comment(pr_review,
initial_header=f"{PRReviewHeader.REGULAR.value} 🔍",
update_header=True,
final_update_message=final_update_message, )
else:
self.git_provider.publish_comment(pr_review)
self.git_provider.remove_initial_comment()
except Exception as e: except Exception as e:
get_logger().error(f"Failed to review PR: {e}") get_logger().error(f"Failed to review PR: {e}")
def _should_publish_review_no_suggestions(self, pr_review: str) -> bool:
return get_settings().pr_reviewer.get('publish_output_no_suggestions', True) or "No major issues detected" not in pr_review
async def _prepare_prediction(self, model: str) -> None: async def _prepare_prediction(self, model: str) -> None:
self.patches_diff = get_pr_diff(self.git_provider, self.patches_diff = get_pr_diff(self.git_provider,
self.token_handler, self.token_handler,