Merge pull request #312 from Codium-ai/tr/fixes_20_9

Enhancing error handling in PR review tools
This commit is contained in:
mrT23
2023-09-20 07:59:02 +03:00
committed by GitHub
4 changed files with 82 additions and 70 deletions

View File

@ -86,14 +86,12 @@ See the [usage guide](./Usage.md) for instructions how to run the different tool
<div align="left">
## Table of Contents
- [Table of Contents](#table-of-contents)
- [Overview](#overview)
- [Try it now](#try-it-now)
- [Installation](#installation)
- [How it works](#how-it-works)
- [Why use PR-Agent?](#why-use-pr-agent)
- [Roadmap](#roadmap)
- [Similar Projects](#similar-projects)
</div>

View File

@ -48,6 +48,7 @@ class PRCodeSuggestions:
get_settings().pr_code_suggestions_prompt.user)
async def run(self):
try:
logging.info('Generating code suggestions for PR...')
if get_settings().config.publish_output:
self.git_provider.publish_comment("Preparing review...", is_temporary=True)
@ -58,6 +59,9 @@ class PRCodeSuggestions:
data = self._prepare_pr_code_suggestions()
else:
data = await retry_with_fallback_models(self._prepare_prediction_extended)
if (not data) or (not 'Code suggestions' in data):
logging.info('No code suggestions found for PR.')
return
if (not self.is_extended and get_settings().pr_code_suggestions.rank_suggestions) or \
(self.is_extended and get_settings().pr_code_suggestions.rank_extended_suggestions):
@ -69,6 +73,8 @@ class PRCodeSuggestions:
self.git_provider.remove_initial_comment()
logging.info('Pushing inline code suggestions...')
self.push_inline_code_suggestions(data)
except Exception as e:
logging.error(f"Failed to generate code suggestions for PR, error: {e}")
async def _prepare_prediction(self, model: str):
logging.info('Getting PR diff...')

View File

@ -63,6 +63,8 @@ class PRDescription:
"""
Generates a PR description using an AI model and publishes it to the PR.
"""
try:
logging.info(f"Generating a PR description {self.pr_id}")
if get_settings().config.publish_output:
self.git_provider.publish_comment("Preparing pr description...", is_temporary=True)
@ -97,6 +99,8 @@ class PRDescription:
current_labels = []
self.git_provider.publish_labels(pr_labels + current_labels)
self.git_provider.remove_initial_comment()
except Exception as e:
logging.error(f"Error generating PR description {self.pr_id}: {e}")
return ""

View File

@ -95,6 +95,8 @@ class PRReviewer:
"""
Review the pull request and generate feedback.
"""
try:
if self.is_auto and not get_settings().pr_reviewer.automatic_review:
logging.info(f'Automatic review is disabled {self.pr_url}')
return None
@ -117,6 +119,8 @@ class PRReviewer:
if get_settings().pr_reviewer.inline_code_comments:
logging.info('Pushing inline code comments...')
self._publish_inline_code_comments()
except Exception as e:
logging.error(f"Failed to review PR: {e}")
async def _prepare_prediction(self, model: str) -> None:
"""