From e55fd64bda9cd7b274bb5a82f7c53871994865b9 Mon Sep 17 00:00:00 2001 From: Sangmin Park Date: Thu, 15 May 2025 18:41:39 +0900 Subject: [PATCH 1/3] Remove unnecessary nested try-except block for cleaner code. Streamlined the import statement to remove an unused reference to `get_git_provider`. --- pr_agent/git_providers/utils.py | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/pr_agent/git_providers/utils.py b/pr_agent/git_providers/utils.py index 1b4232df..51da46c9 100644 --- a/pr_agent/git_providers/utils.py +++ b/pr_agent/git_providers/utils.py @@ -6,8 +6,7 @@ from dynaconf import Dynaconf from starlette_context import context from pr_agent.config_loader import get_settings -from pr_agent.git_providers import (get_git_provider, - get_git_provider_with_context) +from pr_agent.git_providers import get_git_provider_with_context from pr_agent.log import get_logger @@ -17,11 +16,7 @@ def apply_repo_settings(pr_url): if get_settings().config.use_repo_settings_file: repo_settings_file = None try: - try: - repo_settings = context.get("repo_settings", None) - except Exception: - repo_settings = None - pass + repo_settings = context.get("repo_settings", None) if repo_settings is None: # None is different from "", which is a valid value repo_settings = git_provider.get_repo_settings() try: From c79b655864e1f1a61205a5152a82ac61c971b4b1 Mon Sep 17 00:00:00 2001 From: Sangmin Park Date: Thu, 15 May 2025 18:42:08 +0900 Subject: [PATCH 2/3] Fix typo in method parameter name --- pr_agent/identity_providers/identity_provider.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pr_agent/identity_providers/identity_provider.py b/pr_agent/identity_providers/identity_provider.py index 58e5f6c6..0fdb9a37 100644 --- a/pr_agent/identity_providers/identity_provider.py +++ b/pr_agent/identity_providers/identity_provider.py @@ -10,7 +10,7 @@ class Eligibility(Enum): class IdentityProvider(ABC): @abstractmethod - def verify_eligibility(self, git_provider, git_provier_id, pr_url): + def verify_eligibility(self, git_provider, git_provider_id, pr_url): pass @abstractmethod From a3c9fbbf2cebc6143697a3bfcda59b1c225010e2 Mon Sep 17 00:00:00 2001 From: Sangmin Park Date: Thu, 15 May 2025 19:40:40 +0900 Subject: [PATCH 3/3] revert try except --- pr_agent/git_providers/utils.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pr_agent/git_providers/utils.py b/pr_agent/git_providers/utils.py index 51da46c9..0cfbe116 100644 --- a/pr_agent/git_providers/utils.py +++ b/pr_agent/git_providers/utils.py @@ -16,7 +16,11 @@ def apply_repo_settings(pr_url): if get_settings().config.use_repo_settings_file: repo_settings_file = None try: - repo_settings = context.get("repo_settings", None) + try: + repo_settings = context.get("repo_settings", None) + except Exception: + repo_settings = None + pass if repo_settings is None: # None is different from "", which is a valid value repo_settings = git_provider.get_repo_settings() try: