xiaxinhang/pr-agent
1
0
Fork 0
mirror of https://github.com/qodo-ai/pr-agent.git synced 2025-07-06 22:00:40 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: improve CLI argument validation for sensitive parameters with dot notation

Browse Source
This commit is contained in:
mrT23
2025-01-01 15:52:54 +02:00
parent 2c2af93eed
commit d1caa0f15f
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pr_agent/agent/pr_agent.py
View File

@ -67,10 +67,12 @@ class PRAgent:
for arg in args: for arg in args:
if arg.startswith('--'): if arg.startswith('--'):
for forbidden_arg in forbidden_cli_args: for forbidden_arg in forbidden_cli_args:
arg_word = arg.lower()
arg_word = arg_word.replace('__', '.') # replace double underscore with dot, e.g. --openai__key -> --openai.key
forbidden_arg_word = forbidden_arg.lower() forbidden_arg_word = forbidden_arg.lower()
if '.' not in forbidden_arg_word: if '.' not in forbidden_arg_word:
forbidden_arg_word = '.' + forbidden_arg_word forbidden_arg_word = '.' + forbidden_arg_word
if forbidden_arg_word in arg.lower(): if forbidden_arg_word in arg_word:
get_logger().error( get_logger().error(
f"CLI argument for param '{forbidden_arg}' is forbidden. Use instead a configuration file." f"CLI argument for param '{forbidden_arg}' is forbidden. Use instead a configuration file."
) )