1. Move deployment_type to configuration.toml

2. Lint
3. Inject GitHub app installation ID into GitHub provider using the settings mechanism.

pr_agent/git_providers/git_provider.py

@@ -1,5 +1,4 @@
-
-from abc import ABC
+from abc import ABC, abstractmethod
 from dataclasses import dataclass
 
 
@@ -13,27 +12,35 @@ class FilePatchInfo:
 
 
 class GitProvider(ABC):
+    @abstractmethod
     def get_diff_files(self) -> list[FilePatchInfo]:
         pass
 
+    @abstractmethod
     def publish_comment(self, pr_comment: str, is_temporary: bool = False):
         pass
 
+    @abstractmethod
     def remove_initial_comment(self):
         pass
 
+    @abstractmethod
     def get_languages(self):
         pass
 
+    @abstractmethod
     def get_pr_branch(self):
         pass
 
+    @abstractmethod
     def get_user_id(self):
         pass
 
+    @abstractmethod
     def get_pr_description(self):
         pass
 
+
 def get_main_pr_language(languages, files) -> str:
     """
     Get the main language of the commit. Return an empty string if cannot determine.
@@ -72,4 +79,4 @@ def get_main_pr_language(languages, files) -> str:
     except Exception:
         pass
 
-    return main_language_str
+    return main_language_str

pr_agent/git_providers/github_provider.py

@@ -6,6 +6,7 @@ from urllib.parse import urlparse
 from github import AppAuthentication, Github
 
 from pr_agent.config_loader import settings
+
 from .git_provider import FilePatchInfo
 
 

pr_agent/git_providers/gitlab_provider.py

@@ -1,6 +1,8 @@
-from urllib.parse import urlparse
-import gitlab
+import logging
 from typing import Optional, Tuple
+from urllib.parse import urlparse
+
+import gitlab
 
 from pr_agent.config_loader import settings
 
@@ -9,24 +11,28 @@ from .git_provider import FilePatchInfo, GitProvider
 
 class GitLabProvider(GitProvider):
     def __init__(self, merge_request_url: Optional[str] = None):
+        gitlab_url = settings.get("GITLAB.URL", None)
+        if not gitlab_url:
+            raise ValueError("GitLab URL is not set in the config file")
+        gitlab_access_token = settings.get("GITLAB.PERSONAL_ACCESS_TOKEN", None)
+        if not gitlab_access_token:
+            raise ValueError("GitLab personal access token is not set in the config file")
         self.gl = gitlab.Gitlab(
-            settings.get("GITLAB.URL"),
-            private_token=settings.get("GITLAB.PERSONAL_ACCESS_TOKEN")
+            gitlab_url,
+            gitlab_access_token
         )
-
         self.id_project = None
         self.id_mr = None
         self.mr = None
         self.temp_comments = []
-
-        self.set_merge_request(merge_request_url)
+        self._set_merge_request(merge_request_url)
 
     @property
     def pr(self):
         '''The GitLab terminology is merge request (MR) instead of pull request (PR)'''
         return self.mr
 
-    def set_merge_request(self, merge_request_url: str):
+    def _set_merge_request(self, merge_request_url: str):
         self.id_project, self.id_mr = self._parse_merge_request_url(merge_request_url)
         self.mr = self._get_merge_request()