From 31168cd7dec14d82f437958ee778c5ea4df3b46f Mon Sep 17 00:00:00 2001 From: KennyDizi Date: Wed, 27 Dec 2023 10:12:41 +0700 Subject: [PATCH 1/4] Get PR review enable help text from setting --- pr_agent/settings/configuration.toml | 1 + pr_agent/tools/pr_reviewer.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/pr_agent/settings/configuration.toml b/pr_agent/settings/configuration.toml index d4171f3b..16d38309 100644 --- a/pr_agent/settings/configuration.toml +++ b/pr_agent/settings/configuration.toml @@ -38,6 +38,7 @@ enable_review_labels_effort=false require_all_thresholds_for_incremental_review=false minimal_commits_for_incremental_review=0 minimal_minutes_for_incremental_review=0 +enable_help_text=true # Help text is eanabled by default [pr_description] # /describe # publish_labels=true diff --git a/pr_agent/tools/pr_reviewer.py b/pr_agent/tools/pr_reviewer.py index fad8dcd6..4406c271 100644 --- a/pr_agent/tools/pr_reviewer.py +++ b/pr_agent/tools/pr_reviewer.py @@ -252,7 +252,7 @@ class PRReviewer: user = self.git_provider.get_user_id() # Add help text if gfm_markdown is supported - if self.git_provider.is_supported("gfm_markdown"): + if self.git_provider.is_supported("gfm_markdown") & get_settings().pr_reviewer.enable_help_text: markdown_text += "\n\n
✨ Usage tips:
\n\n" bot_user = "[bot]" if get_settings().github_app.override_deployment_type else get_settings().github_app.bot_user if user and bot_user not in user and not get_settings().get("CONFIG.CLI_MODE", False): From 37b040b50a0c8423731569e1c400d93a1f172951 Mon Sep 17 00:00:00 2001 From: KennyDizi Date: Wed, 27 Dec 2023 10:17:08 +0700 Subject: [PATCH 2/4] Use 'and' in lieu of '&' operator --- pr_agent/tools/pr_reviewer.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pr_agent/tools/pr_reviewer.py b/pr_agent/tools/pr_reviewer.py index 4406c271..94a4e238 100644 --- a/pr_agent/tools/pr_reviewer.py +++ b/pr_agent/tools/pr_reviewer.py @@ -252,7 +252,7 @@ class PRReviewer: user = self.git_provider.get_user_id() # Add help text if gfm_markdown is supported - if self.git_provider.is_supported("gfm_markdown") & get_settings().pr_reviewer.enable_help_text: + if self.git_provider.is_supported("gfm_markdown") and get_settings().pr_reviewer.enable_help_text: markdown_text += "\n\n
✨ Usage tips:
\n\n" bot_user = "[bot]" if get_settings().github_app.override_deployment_type else get_settings().github_app.bot_user if user and bot_user not in user and not get_settings().get("CONFIG.CLI_MODE", False): From dff31ff8f5e46c948160ce3e825eeb4c5da72f41 Mon Sep 17 00:00:00 2001 From: KennyDizi Date: Wed, 27 Dec 2023 10:17:56 +0700 Subject: [PATCH 3/4] feat: Fix typo --- pr_agent/settings/configuration.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pr_agent/settings/configuration.toml b/pr_agent/settings/configuration.toml index 16d38309..fe54b123 100644 --- a/pr_agent/settings/configuration.toml +++ b/pr_agent/settings/configuration.toml @@ -38,7 +38,7 @@ enable_review_labels_effort=false require_all_thresholds_for_incremental_review=false minimal_commits_for_incremental_review=0 minimal_minutes_for_incremental_review=0 -enable_help_text=true # Help text is eanabled by default +enable_help_text=true # Help text is enabled by default [pr_description] # /describe # publish_labels=true From fce52a66ff548f9b26280511332117eae4353639 Mon Sep 17 00:00:00 2001 From: KennyDizi Date: Wed, 27 Dec 2023 10:22:43 +0700 Subject: [PATCH 4/4] feat: Update enable_help_text flag explaination --- pr_agent/settings/configuration.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pr_agent/settings/configuration.toml b/pr_agent/settings/configuration.toml index fe54b123..53e3b984 100644 --- a/pr_agent/settings/configuration.toml +++ b/pr_agent/settings/configuration.toml @@ -38,7 +38,7 @@ enable_review_labels_effort=false require_all_thresholds_for_incremental_review=false minimal_commits_for_incremental_review=0 minimal_minutes_for_incremental_review=0 -enable_help_text=true # Help text is enabled by default +enable_help_text=true # Determines whether to include help text in the PR review. Enabled by default. [pr_description] # /describe # publish_labels=true