xiaxinhang/pr-agent
1
0
Fork 0
mirror of https://github.com/qodo-ai/pr-agent.git synced 2025-07-04 12:50:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

Improve comment thread retrieval by using in_reply_to_id instead of line numbers

Browse Source
This commit is contained in:
benedict.lee
2025-04-21 16:28:42 +09:00
parent 9c06b6b266
commit a434d0af9b
1 changed files with 21 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
pr_agent/git_providers/github_provider.py
View File

@ -431,36 +431,40 @@ class GithubProvider(GitProvider):
def get_review_thread_comments(self, comment_id: int) -> list[dict]: def get_review_thread_comments(self, comment_id: int) -> list[dict]:
""" """
Retrieves all comments in the same line as the given comment. Retrieves all comments in the same thread as the given comment.
Args: Args:
comment_id: Review comment ID comment_id: Review comment ID
Returns: Returns:
List of comments on the same line List of comments in the same thread
""" """
try: try:
# Get the original comment to find its location # Fetch all comments with a single API call
comment = self.pr.get_comment(comment_id)
if not comment:
return []
# Extract file path and line number
file_path = comment.path
line_number = comment.raw_data["line"] if "line" in comment.raw_data else comment.raw_data.get("original_line")
# Get all comments
all_comments = list(self.pr.get_comments()) all_comments = list(self.pr.get_comments())
# Filter comments on the same line of the same file # Find the target comment by ID
target_comment = next((c for c in all_comments if c.id == comment_id), None)
if not target_comment:
return []
# First, identify if this is a reply to another comment
root_comment_id = target_comment.raw_data.get("in_reply_to_id", target_comment.id)
if root_comment_id != target_comment.id:
# If this is a reply, find the root comment
root_comment = next((c for c in all_comments if c.id == root_comment_id), None)
if root_comment:
target_comment = root_comment
# Build the thread - include the root comment and all replies to it
thread_comments = [ thread_comments = [
c for c in all_comments c for c in all_comments if
if c.path == file_path and (c.raw_data.get("line") == line_number or c.raw_data.get("original_line") == line_number) c.id == target_comment.id or c.raw_data.get("in_reply_to_id") == target_comment.id
] ]
# Sort chronologically # Sort chronologically
thread_comments.sort(key=lambda c: c.created_at) thread_comments.sort(key=lambda c: c.created_at)
return thread_comments return thread_comments
except Exception as e: except Exception as e: