xiaxinhang/pr-agent
1
0
Fork 0
mirror of https://github.com/qodo-ai/pr-agent.git synced 2025-07-04 21:00:40 +08:00
Code Issues Packages Projects Releases Wiki Activity

PR Review

Browse Source
This commit is contained in:
Hussam.lawen
2024-02-08 15:25:43 +02:00
parent 4447110118
commit a3f4c44632
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
pr_agent/tools/pr_reviewer.py
View File

@ -128,7 +128,7 @@ class PRReviewer:
# publish the review # publish the review
if get_settings().pr_reviewer.persistent_comment and not self.incremental.is_incremental: if get_settings().pr_reviewer.persistent_comment and not self.incremental.is_incremental:
self.git_provider.publish_persistent_comment(pr_comment, self.git_provider.publish_persistent_comment(pr_comment,
initial_header="## PR Analysis", initial_header="## PR Review",
update_header=True) update_header=True)
else: else:
self.git_provider.publish_comment(pr_comment) self.git_provider.publish_comment(pr_comment)
@ -198,9 +198,9 @@ class PRReviewer:
if security_concerns is not None: if security_concerns is not None:
del pr_feedback['Security concerns'] del pr_feedback['Security concerns']
if type(security_concerns) == bool and security_concerns == False: if type(security_concerns) == bool and security_concerns == False:
data.setdefault('PR Analysis', {})['Security concerns'] = 'No security concerns found' data.setdefault('PR Review', {})['Security concerns'] = 'No security concerns found'
else: else:
data.setdefault('PR Analysis', {})['Security concerns'] = security_concerns data.setdefault('PR Review', {})['Security concerns'] = security_concerns
# #
if 'Code feedback' in pr_feedback: if 'Code feedback' in pr_feedback:
@ -376,12 +376,12 @@ class PRReviewer:
try: try:
review_labels = [] review_labels = []
if get_settings().pr_reviewer.enable_review_labels_effort: if get_settings().pr_reviewer.enable_review_labels_effort:
estimated_effort = data['PR Analysis']['Estimated effort to review [1-5]'] estimated_effort = data['PR Review']['Estimated effort to review [1-5]']
estimated_effort_number = int(estimated_effort.split(',')[0]) estimated_effort_number = int(estimated_effort.split(',')[0])
if 1 <= estimated_effort_number <= 5: # 1, because ... if 1 <= estimated_effort_number <= 5: # 1, because ...
review_labels.append(f'Review effort [1-5]: {estimated_effort_number}') review_labels.append(f'Review effort [1-5]: {estimated_effort_number}')
if get_settings().pr_reviewer.enable_review_labels_security: if get_settings().pr_reviewer.enable_review_labels_security:
security_concerns = data['PR Analysis']['Security concerns'] # yes, because ... security_concerns = data['PR Review']['Security concerns'] # yes, because ...
security_concerns_bool = 'yes' in security_concerns.lower() or 'true' in security_concerns.lower() security_concerns_bool = 'yes' in security_concerns.lower() or 'true' in security_concerns.lower()
if security_concerns_bool: if security_concerns_bool:
review_labels.append('Possible security concern') review_labels.append('Possible security concern')