diff --git a/README.md b/README.md index a2afa596..b6514c05 100644 --- a/README.md +++ b/README.md @@ -183,7 +183,6 @@ Here is a quick overview of the different sub-tools of PR Reviewer: - PR Analysis - Summarize main theme - - PR description and title - PR type classification - Is the PR covered by relevant tests - Is this a focused PR @@ -199,7 +198,6 @@ This is how a typical output of the PR Reviewer looks like: #### PR Analysis - ๐ŸŽฏ **Main theme:** Adding language extension handler and token handler -- ๐Ÿ” **Description and title:** Yes - ๐Ÿ“Œ **Type of PR:** Enhancement - ๐Ÿงช **Relevant tests added:** No - โœจ **Focused PR:** Yes, the PR is focused on adding two new handlers for language extension and token counting. diff --git a/pr_agent/algo/utils.py b/pr_agent/algo/utils.py index 67c6f52b..ff4bbdac 100644 --- a/pr_agent/algo/utils.py +++ b/pr_agent/algo/utils.py @@ -11,7 +11,6 @@ def convert_to_markdown(output_data: dict) -> str: emojis = { "Main theme": "๐ŸŽฏ", - "Description and title": "๐Ÿ”", "Type of PR": "๐Ÿ“Œ", "Relevant tests added": "๐Ÿงช", "Unrelated changes": "โš ๏ธ", diff --git a/pr_agent/settings/pr_reviewer_prompts.toml b/pr_agent/settings/pr_reviewer_prompts.toml index 36b4c8cd..f87563b7 100644 --- a/pr_agent/settings/pr_reviewer_prompts.toml +++ b/pr_agent/settings/pr_reviewer_prompts.toml @@ -13,10 +13,6 @@ You must use the following JSON schema to format your answer: "type": "string", "description": "a short explanation of the PR" }, - "Description and title": { - "type": "string", - "description": "yes\\no question: does this PR have a relevant description and title" - }, "Type of PR": { "type": "string", "enum": ["Bug fix", "Tests", "Bug fix with tests", "Refactoring", "Enhancement", "Documentation", "Other"] @@ -37,7 +33,7 @@ You must use the following JSON schema to format your answer: "PR Feedback": { "General PR suggestions": { "type": "string", - "description": "important suggestions for the contributors and maintainers of this PR, may include overall structure, primary purpose and best practices. consider using specific filenames, classes and functions names. explain yourself!" + "description": "General important suggestions for the contributors and maintainers of this PR. May include suggestions for overall structure, primary purpose, best practices, etc. consider using specific filenames, classes and functions names. explain yourself!" }, "Code suggestions": { "type": "array", @@ -75,7 +71,6 @@ Example output: "PR Analysis": { "Main theme": "xxx", - "Description and title": "Yes", "Type of PR": "Bug fix", {%- if require_tests %} "Relevant tests added": "No", diff --git a/tests/unit/test_convert_to_markdown.py b/tests/unit/test_convert_to_markdown.py index a40574ae..02e3ceac 100644 --- a/tests/unit/test_convert_to_markdown.py +++ b/tests/unit/test_convert_to_markdown.py @@ -46,7 +46,6 @@ class TestConvertToMarkdown: def test_simple_dictionary_input(self): input_data = { 'Main theme': 'Test', - 'Description and title': 'Test description', 'Type of PR': 'Test type', 'Relevant tests added': 'no', 'Unrelated changes': 'n/a', # won't be included in the output @@ -69,7 +68,6 @@ class TestConvertToMarkdown: } expected_output = """\ - ๐ŸŽฏ **Main theme:** Test -- ๐Ÿ” **Description and title:** Test description - ๐Ÿ“Œ **Type of PR:** Test type - ๐Ÿงช **Relevant tests added:** no - โœจ **Focused PR:** Yes @@ -108,7 +106,6 @@ class TestConvertToMarkdown: def test_dictionary_input_containing_only_empty_dictionaries(self): input_data = { 'Main theme': {}, - 'Description and title': {}, 'Type of PR': {}, 'Relevant tests added': {}, 'Unrelated changes': {},