xiaxinhang/pr-agent
1
0
Fork 0
mirror of https://github.com/qodo-ai/pr-agent.git synced 2025-07-03 12:20:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: rm invalid error handling

Browse Source
This commit is contained in:
tomoya-kawaguchi
2025-05-29 14:03:38 +09:00
parent d1e8d267f6
commit 984d627300
2 changed files with 0 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
pr_agent/secret_providers/aws_secrets_manager_provider.py
View File

@ -51,20 +51,6 @@ class AWSSecretsManagerProvider(SecretProvider):
SecretId=secret_name, SecretId=secret_name,
SecretString=secret_value SecretString=secret_value
) )
except ClientError as e:
if e.response['Error']['Code'] == 'ResourceNotFoundException':
# Create new secret if it doesn't exist
try:
self.client.create_secret(
Name=secret_name,
SecretString=secret_value
)
except Exception as create_error:
get_logger().error(f"Failed to store secret {secret_name} in AWS Secrets Manager: {create_error}")
raise create_error
else:
get_logger().error(f"Failed to store secret {secret_name} in AWS Secrets Manager: {e}")
raise e
except Exception as e: except Exception as e:
get_logger().error(f"Failed to store secret {secret_name} in AWS Secrets Manager: {e}") get_logger().error(f"Failed to store secret {secret_name} in AWS Secrets Manager: {e}")
raise e raise e

13
tests/unittest/test_aws_secrets_manager_provider.py
View File

@ -72,19 +72,6 @@ class TestAWSSecretsManagerProvider:
SecretString='test-value' SecretString='test-value'
) )
def test_store_secret_create_new(self):
provider, mock_client = self._provider()
mock_client.update_secret.side_effect = ClientError(
{'Error': {'Code': 'ResourceNotFoundException'}}, 'UpdateSecret'
)
mock_client.create_secret.return_value = {}
provider.store_secret('new-secret', 'test-value')
mock_client.create_secret.assert_called_once_with(
Name='new-secret',
SecretString='test-value'
)
def test_init_failure_invalid_config(self): def test_init_failure_invalid_config(self):
with patch('pr_agent.secret_providers.aws_secrets_manager_provider.get_settings') as mock_get_settings: with patch('pr_agent.secret_providers.aws_secrets_manager_provider.get_settings') as mock_get_settings:
settings = MagicMock() settings = MagicMock()