diff --git a/pr_agent/secret_providers/aws_secrets_manager_provider.py b/pr_agent/secret_providers/aws_secrets_manager_provider.py index e14d3d87..dbb3f044 100644 --- a/pr_agent/secret_providers/aws_secrets_manager_provider.py +++ b/pr_agent/secret_providers/aws_secrets_manager_provider.py @@ -51,20 +51,6 @@ class AWSSecretsManagerProvider(SecretProvider): SecretId=secret_name, SecretString=secret_value ) - except ClientError as e: - if e.response['Error']['Code'] == 'ResourceNotFoundException': - # Create new secret if it doesn't exist - try: - self.client.create_secret( - Name=secret_name, - SecretString=secret_value - ) - except Exception as create_error: - get_logger().error(f"Failed to store secret {secret_name} in AWS Secrets Manager: {create_error}") - raise create_error - else: - get_logger().error(f"Failed to store secret {secret_name} in AWS Secrets Manager: {e}") - raise e except Exception as e: get_logger().error(f"Failed to store secret {secret_name} in AWS Secrets Manager: {e}") raise e diff --git a/tests/unittest/test_aws_secrets_manager_provider.py b/tests/unittest/test_aws_secrets_manager_provider.py index a966555c..f84743ca 100644 --- a/tests/unittest/test_aws_secrets_manager_provider.py +++ b/tests/unittest/test_aws_secrets_manager_provider.py @@ -72,19 +72,6 @@ class TestAWSSecretsManagerProvider: SecretString='test-value' ) - def test_store_secret_create_new(self): - provider, mock_client = self._provider() - mock_client.update_secret.side_effect = ClientError( - {'Error': {'Code': 'ResourceNotFoundException'}}, 'UpdateSecret' - ) - mock_client.create_secret.return_value = {} - - provider.store_secret('new-secret', 'test-value') - mock_client.create_secret.assert_called_once_with( - Name='new-secret', - SecretString='test-value' - ) - def test_init_failure_invalid_config(self): with patch('pr_agent.secret_providers.aws_secrets_manager_provider.get_settings') as mock_get_settings: settings = MagicMock()