protections for 'get_secret_provider'

pr_agent/secret_providers/__init__.py

@@ -2,15 +2,18 @@ from pr_agent.config_loader import get_settings
 
 
 def get_secret_provider():
-    try:
+    if not get_settings().get("CONFIG.SECRET_PROVIDER"):
-        provider_id = get_settings().config.secret_provider
+        return None
-    except AttributeError as e:
+
-        raise ValueError("secret_provider is a required attribute in the configuration file") from e
+    provider_id = get_settings().config.secret_provider
-    try:
+    if provider_id == 'google_cloud_storage':
-        if provider_id == 'google_cloud_storage':
+        try:
             from pr_agent.secret_providers.google_cloud_storage_secret_provider import GoogleCloudStorageSecretProvider
             return GoogleCloudStorageSecretProvider()
-        else:
+        except Exception as e:
-            raise ValueError(f"Unknown secret provider: {provider_id}")
+            raise ValueError(f"Failed to initialize google_cloud_storage secret provider {provider_id}") from e
-    except Exception as e:
+    else:
-        raise ValueError(f"Failed to initialize secret provider {provider_id}") from e
+        raise ValueError("Unknown SECRET_PROVIDER")
+
+
+

pr_agent/servers/bitbucket_app.py

@@ -26,7 +26,8 @@ from pr_agent.tools.pr_reviewer import PRReviewer
 
 setup_logger(fmt=LoggingFormat.JSON)
 router = APIRouter()
-secret_provider = get_secret_provider()
+secret_provider = get_secret_provider() if get_settings().get("CONFIG.SECRET_PROVIDER") else None
+
 
 async def get_bearer_token(shared_secret: str, client_key: str):
     try: