xiaxinhang/pr-agent
1
0
Fork 0
mirror of https://github.com/qodo-ai/pr-agent.git synced 2025-07-04 21:00:40 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor: reuse IF condition in _should_publish_review

Browse Source
This commit is contained in:
Alessio
2025-06-12 17:54:13 +03:00
parent e8770beba1
commit 94253853cd
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
pr_agent/tools/pr_reviewer.py
View File

@ -161,7 +161,7 @@ class PRReviewer:
if get_settings().config.publish_output: if get_settings().config.publish_output:
# publish the review # publish the review
if get_settings().pr_reviewer.persistent_comment and not self.incremental.is_incremental: if get_settings().pr_reviewer.persistent_comment and not self.incremental.is_incremental:
if get_settings().pr_reviewer.get('publish_output_no_suggestions', True) or "No major issues detected" not in pr_review: if self._should_publish_review(pr_review):
final_update_message = get_settings().pr_reviewer.final_update_message final_update_message = get_settings().pr_reviewer.final_update_message
self.git_provider.publish_persistent_comment(pr_review, self.git_provider.publish_persistent_comment(pr_review,
initial_header=f"{PRReviewHeader.REGULAR.value} 🔍", initial_header=f"{PRReviewHeader.REGULAR.value} 🔍",
@ -170,7 +170,7 @@ class PRReviewer:
else: else:
get_logger().info("Review output is not published: no major issues detected.") get_logger().info("Review output is not published: no major issues detected.")
else: else:
if get_settings().pr_reviewer.get('publish_output_no_suggestions', True) or "No major issues detected" not in pr_review: if self._should_publish_review(pr_review):
self.git_provider.publish_comment(pr_review) self.git_provider.publish_comment(pr_review)
else: else:
get_logger().info("Review output is not published: no major issues detected.") get_logger().info("Review output is not published: no major issues detected.")
@ -183,6 +183,9 @@ class PRReviewer:
except Exception as e: except Exception as e:
get_logger().error(f"Failed to review PR: {e}") get_logger().error(f"Failed to review PR: {e}")
def _should_publish_review(self, pr_review: str) -> bool:
return get_settings().pr_reviewer.get('publish_output_no_suggestions', True) or "No major issues detected" not in pr_review
async def _prepare_prediction(self, model: str) -> None: async def _prepare_prediction(self, model: str) -> None:
self.patches_diff = get_pr_diff(self.git_provider, self.patches_diff = get_pr_diff(self.git_provider,
self.token_handler, self.token_handler,