xiaxinhang/pr-agent
1
0
Fork 0
mirror of https://github.com/qodo-ai/pr-agent.git synced 2025-07-04 04:40:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: improve null safety in GitLab webhook handler

Browse Source
This commit is contained in:
mrT23
2025-02-27 11:53:11 +02:00
parent e71c0f1805
commit 7cf521c001
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
pr_agent/servers/gitlab_webhook.py
View File

@ -198,9 +198,9 @@ async def gitlab_webhook(background_tasks: BackgroundTasks, request: Request):
# ignore MRs based on title, labels, source and target branches # ignore MRs based on title, labels, source and target branches
if not should_process_pr_logic(data): if not should_process_pr_logic(data):
return JSONResponse(status_code=status.HTTP_200_OK, content=jsonable_encoder({"message": "success"})) return JSONResponse(status_code=status.HTTP_200_OK, content=jsonable_encoder({"message": "success"}))
object_attributes = data.get('object_attributes', {})
if data['object_attributes'].get('action') in ['open', 'reopen']: if object_attributes.get('action') in ['open', 'reopen']:
url = data['object_attributes'].get('url') url = object_attributes.get('url')
get_logger().info(f"New merge request: {url}") get_logger().info(f"New merge request: {url}")
if is_draft(data): if is_draft(data):
get_logger().info(f"Skipping draft MR: {url}") get_logger().info(f"Skipping draft MR: {url}")
@ -209,8 +209,8 @@ async def gitlab_webhook(background_tasks: BackgroundTasks, request: Request):
await _perform_commands_gitlab("pr_commands", PRAgent(), url, log_context, data) await _perform_commands_gitlab("pr_commands", PRAgent(), url, log_context, data)
# for push event triggered merge requests # for push event triggered merge requests
elif data['object_attributes'].get('action') == 'update' and data['object_attributes'].get('oldrev'): elif object_attributes.get('action') == 'update' and object_attributes.get('oldrev'):
url = data['object_attributes'].get('url') url = object_attributes.get('url')
get_logger().info(f"New merge request: {url}") get_logger().info(f"New merge request: {url}")
if is_draft(data): if is_draft(data):
get_logger().info(f"Skipping draft MR: {url}") get_logger().info(f"Skipping draft MR: {url}")
@ -227,8 +227,8 @@ async def gitlab_webhook(background_tasks: BackgroundTasks, request: Request):
await _perform_commands_gitlab("push_commands", PRAgent(), url, log_context, data) await _perform_commands_gitlab("push_commands", PRAgent(), url, log_context, data)
# for draft to ready triggered merge requests # for draft to ready triggered merge requests
elif data['object_attributes'].get('action') == 'update' and is_draft_ready(data): elif object_attributes.get('action') == 'update' and is_draft_ready(data):
url = data['object_attributes'].get('url') url = object_attributes.get('url')
get_logger().info(f"Draft MR is ready: {url}") get_logger().info(f"Draft MR is ready: {url}")
# same as open MR # same as open MR