From 78cabf28a49daa4ac22a8953786f5263d5f6e508 Mon Sep 17 00:00:00 2001 From: mrT23 Date: Tue, 12 Mar 2024 18:25:42 +0200 Subject: [PATCH] Update label comparison logic in pr_reviewer.py and pr_description.py to consider unordered lists --- pr_agent/tools/pr_description.py | 2 +- pr_agent/tools/pr_reviewer.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pr_agent/tools/pr_description.py b/pr_agent/tools/pr_description.py index d5ca914c..28df555f 100644 --- a/pr_agent/tools/pr_description.py +++ b/pr_agent/tools/pr_description.py @@ -123,7 +123,7 @@ class PRDescription: user_labels = get_user_labels(original_labels) new_labels = pr_labels + user_labels get_logger().debug(f"published labels", artifact=new_labels) - if new_labels != original_labels: + if sorted(new_labels) != sorted(original_labels): self.git_provider.publish_labels(new_labels) else: get_logger().debug(f"Labels are the same, not updating") diff --git a/pr_agent/tools/pr_reviewer.py b/pr_agent/tools/pr_reviewer.py index 696b62fb..19f9a163 100644 --- a/pr_agent/tools/pr_reviewer.py +++ b/pr_agent/tools/pr_reviewer.py @@ -378,7 +378,7 @@ class PRReviewer: else: current_labels_filtered = [] new_labels = review_labels + current_labels_filtered - if (current_labels or review_labels) and new_labels != current_labels: + if (current_labels or review_labels) and sorted(new_labels) != sorted(current_labels): get_logger().info(f"Setting review labels:\n{review_labels + current_labels_filtered}") self.git_provider.publish_labels(new_labels) else: