xiaxinhang/pr-agent
1
0
Fork 0
mirror of https://github.com/qodo-ai/pr-agent.git synced 2025-07-05 05:10:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: avoid incorrect ToDo header

Browse Source
This commit is contained in:
joosomi
2025-05-24 03:04:59 +09:00
parent 788c0c12e6
commit 66131854c1
2 changed files with 4 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pr_agent/algo/utils.py
View File

@ -154,7 +154,7 @@ def convert_to_markdown_v2(output_data: dict,
for key, value in output_data['review'].items(): for key, value in output_data['review'].items():
if value is None or value == '' or value == {} or value == []: if value is None or value == '' or value == {} or value == []:
if key.lower() not in ['can_be_split', 'key_issues_to_review', 'todo_sections']: if key.lower() not in ['can_be_split', 'key_issues_to_review']:
continue continue
key_nice = key.replace('_', ' ').capitalize() key_nice = key.replace('_', ' ').capitalize()
emoji = emojis.get(key_nice, "") emoji = emojis.get(key_nice, "")

14
pr_agent/settings/pr_reviewer_prompts.toml
View File

@ -108,7 +108,7 @@ class Review(BaseModel):
security_concerns: str = Field(description="Does this PR code introduce possible vulnerabilities such as exposure of sensitive information (e.g., API keys, secrets, passwords), or security concerns like SQL injection, XSS, CSRF, and others ? Answer 'No' (without explaining why) if there are no possible issues. If there are security concerns or issues, start your answer with a short header, such as: 'Sensitive information exposure: ...', 'SQL injection: ...' etc. Explain your answer. Be specific and give examples if possible") security_concerns: str = Field(description="Does this PR code introduce possible vulnerabilities such as exposure of sensitive information (e.g., API keys, secrets, passwords), or security concerns like SQL injection, XSS, CSRF, and others ? Answer 'No' (without explaining why) if there are no possible issues. If there are security concerns or issues, start your answer with a short header, such as: 'Sensitive information exposure: ...', 'SQL injection: ...' etc. Explain your answer. Be specific and give examples if possible")
{%- endif %} {%- endif %}
{%- if require_todo_scan %} {%- if require_todo_scan %}
todo_sections: List[TodoSection] = Field(description="A list of TODO comments found in the code. Return an empty list if there are no TODO comments.") todo_sections: Union[List[TodoSection], str] = Field(description="A list of TODO comments found in the code. Return 'No' (as a string) if there are no TODO comments.")
{%- endif %} {%- endif %}
{%- if require_can_be_split_review %} {%- if require_can_be_split_review %}
can_be_split: List[SubPR] = Field(min_items=0, max_items=3, description="Can this PR, which contains {{ num_pr_files }} changed files in total, be divided into smaller sub-PRs with distinct tasks that can be reviewed and merged independently, regardless of the order ? Make sure that the sub-PRs are indeed independent, with no code dependencies between them, and that each sub-PR represent a meaningful independent task. Output an empty list if the PR code does not need to be split.") can_be_split: List[SubPR] = Field(min_items=0, max_items=3, description="Can this PR, which contains {{ num_pr_files }} changed files in total, be divided into smaller sub-PRs with distinct tasks that can be reviewed and merged independently, regardless of the order ? Make sure that the sub-PRs are indeed independent, with no code dependencies between them, and that each sub-PR represent a meaningful independent task. Output an empty list if the PR code does not need to be split.")
@ -157,11 +157,7 @@ review:
security_concerns: | security_concerns: |
No No
todo_sections: todo_sections:
- relevant_file: | No
src/file1.py
line_number: 13
content: |
...
{%- if require_can_be_split_review %} {%- if require_can_be_split_review %}
can_be_split: can_be_split:
- relevant_files: - relevant_files:
@ -281,11 +277,7 @@ review:
security_concerns: | security_concerns: |
No No
todo_sections: todo_sections:
- relevant_file: | No
...
line_number: ...
content: |
...
{%- if require_can_be_split_review %} {%- if require_can_be_split_review %}
can_be_split: can_be_split:
- relevant_files: - relevant_files: