xiaxinhang/pr-agent
1
0
Fork 0
mirror of https://github.com/qodo-ai/pr-agent.git synced 2025-07-05 05:10:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: improve error handling and null safety in PR description tool

Browse Source
This commit is contained in:
mrT23
2025-02-26 21:33:40 +02:00
parent 9a9acef0e8
commit 64e5a87530
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
pr_agent/tools/pr_description.py
View File

@ -328,7 +328,10 @@ class PRDescription:
original_prediction_dict = {"pr_files": original_prediction_loaded} original_prediction_dict = {"pr_files": original_prediction_loaded}
else: else:
original_prediction_dict = original_prediction_loaded original_prediction_dict = original_prediction_loaded
filenames_predicted = [file['filename'].strip() for file in original_prediction_dict.get('pr_files', [])] if original_prediction_dict:
filenames_predicted = [file.get('filename', '').strip() for file in original_prediction_dict.get('pr_files', [])]
else:
filenames_predicted = []
# extend the prediction with additional files not included in the original prediction # extend the prediction with additional files not included in the original prediction
pr_files = self.git_provider.get_diff_files() pr_files = self.git_provider.get_diff_files()
@ -368,8 +371,12 @@ class PRDescription:
if counter_extra_files > 0: if counter_extra_files > 0:
get_logger().info(f"Adding {counter_extra_files} unprocessed extra files to table prediction") get_logger().info(f"Adding {counter_extra_files} unprocessed extra files to table prediction")
prediction_extra_dict = load_yaml(prediction_extra, keys_fix_yaml=self.keys_fix) prediction_extra_dict = load_yaml(prediction_extra, keys_fix_yaml=self.keys_fix)
if isinstance(original_prediction_dict, dict) and isinstance(prediction_extra_dict, dict): if original_prediction_dict and isinstance(original_prediction_dict, dict) and \
original_prediction_dict["pr_files"].extend(prediction_extra_dict["pr_files"]) isinstance(prediction_extra_dict, dict) and "pr_files" in prediction_extra_dict:
if "pr_files" in original_prediction_dict:
original_prediction_dict["pr_files"].extend(prediction_extra_dict["pr_files"])
else:
original_prediction_dict["pr_files"] = prediction_extra_dict["pr_files"]
new_yaml = yaml.dump(original_prediction_dict) new_yaml = yaml.dump(original_prediction_dict)
if load_yaml(new_yaml, keys_fix_yaml=self.keys_fix): if load_yaml(new_yaml, keys_fix_yaml=self.keys_fix):
prediction = new_yaml prediction = new_yaml
@ -378,7 +385,7 @@ class PRDescription:
return prediction return prediction
except Exception as e: except Exception as e:
get_logger().error(f"Error extending uncovered files {self.pr_id}: {e}") get_logger().exception(f"Error extending uncovered files {self.pr_id}", artifact={"error": e})
return original_prediction return original_prediction