From 5954c7cec29458555ccc248b6b5f702409d8d703 Mon Sep 17 00:00:00 2001 From: mrT23 Date: Sun, 18 Aug 2024 08:14:37 +0300 Subject: [PATCH] Add logging for empty PR files and update warning for empty diffs in pr_reviewer.py --- pr_agent/tools/pr_reviewer.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pr_agent/tools/pr_reviewer.py b/pr_agent/tools/pr_reviewer.py index b7c39fac..a740efa2 100644 --- a/pr_agent/tools/pr_reviewer.py +++ b/pr_agent/tools/pr_reviewer.py @@ -1,5 +1,6 @@ import copy import datetime +import traceback from collections import OrderedDict from functools import partial from typing import List, Tuple @@ -96,6 +97,10 @@ class PRReviewer: async def run(self) -> None: try: + if not self.git_provider.get_files(): + get_logger().info(f"PR has no files: {self.pr_url}, skipping review") + return None + if self.incremental.is_incremental and not self._can_run_incremental_review(): return None @@ -158,7 +163,7 @@ class PRReviewer: get_logger().debug(f"PR diff", diff=self.patches_diff) self.prediction = await self._get_prediction(model) else: - get_logger().error(f"Error getting PR diff") + get_logger().warning(f"Empty diff for PR: {self.pr_url}") self.prediction = None async def _get_prediction(self, model: str) -> str: