This commit is contained in:
mrT23
2024-02-09 11:11:03 +02:00
parent f74b35fb6f
commit 555151602f
4 changed files with 9 additions and 7 deletions

View File

@ -240,8 +240,8 @@ class BitbucketProvider(GitProvider):
def generate_link_to_relevant_line_number(self, suggestion) -> str: def generate_link_to_relevant_line_number(self, suggestion) -> str:
try: try:
relevant_file = suggestion['relevant_file'].strip('`').strip("'") relevant_file = suggestion['relevant_file'].strip('`').strip("'").rstrip()
relevant_line_str = suggestion['relevant_line'] relevant_line_str = suggestion['relevant_line'].rstrip()
if not relevant_line_str: if not relevant_line_str:
return "" return ""

View File

@ -246,8 +246,8 @@ class BitbucketServerProvider(GitProvider):
def generate_link_to_relevant_line_number(self, suggestion) -> str: def generate_link_to_relevant_line_number(self, suggestion) -> str:
try: try:
relevant_file = suggestion['relevant_file'].strip('`').strip("'") relevant_file = suggestion['relevant_file'].strip('`').strip("'").rstrip()
relevant_line_str = suggestion['relevant_line'] relevant_line_str = suggestion['relevant_line'].rstrip()
if not relevant_line_str: if not relevant_line_str:
return "" return ""

View File

@ -450,8 +450,8 @@ class GitLabProvider(GitProvider):
def generate_link_to_relevant_line_number(self, suggestion) -> str: def generate_link_to_relevant_line_number(self, suggestion) -> str:
try: try:
relevant_file = suggestion['relevant_file'].strip('`').strip("'") relevant_file = suggestion['relevant_file'].strip('`').strip("'").rstrip()
relevant_line_str = suggestion['relevant_line'] relevant_line_str = suggestion['relevant_line'].rstrip()
if not relevant_line_str: if not relevant_line_str:
return "" return ""

View File

@ -261,7 +261,9 @@ class PRReviewer:
if get_settings().pr_reviewer.num_code_suggestions == 0: if get_settings().pr_reviewer.num_code_suggestions == 0:
return return
data = load_yaml(self.prediction.strip()) data = load_yaml(self.prediction.strip(),
keys_fix_yaml=["estimated_effort_to_review_[1-5]:", "security_concerns:", "possible_issues:",
"relevant_file:", "relevant_line:", "suggestion:"])
comments: List[str] = [] comments: List[str] = []
for suggestion in data.get('PR Feedback', {}).get('Code feedback', []): for suggestion in data.get('PR Feedback', {}).get('Code feedback', []):
relevant_file = suggestion.get('relevant_file', '').strip() relevant_file = suggestion.get('relevant_file', '').strip()