From 4db428456dfe26d9caf64141e4d2fa5b7b676359 Mon Sep 17 00:00:00 2001 From: mrT23 Date: Sat, 15 Jun 2024 20:10:46 +0300 Subject: [PATCH] Refactor `filter_bad_extensions` and `is_valid_file` functions to improve code readability and reusability --- pr_agent/algo/language_handler.py | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/pr_agent/algo/language_handler.py b/pr_agent/algo/language_handler.py index 83f7b85e..91419368 100644 --- a/pr_agent/algo/language_handler.py +++ b/pr_agent/algo/language_handler.py @@ -5,17 +5,20 @@ from pr_agent.config_loader import get_settings -# Bad Extensions, source: https://github.com/EleutherAI/github-downloader/blob/345e7c4cbb9e0dc8a0615fd995a08bf9d73b3fe6/download_repo_text.py # noqa: E501 -bad_extensions = get_settings().bad_extensions.default -if get_settings().config.use_extra_bad_extensions: - bad_extensions += get_settings().bad_extensions.extra - def filter_bad_extensions(files): - return [f for f in files if f.filename is not None and is_valid_file(f.filename)] + # Bad Extensions, source: https://github.com/EleutherAI/github-downloader/blob/345e7c4cbb9e0dc8a0615fd995a08bf9d73b3fe6/download_repo_text.py # noqa: E501 + bad_extensions = get_settings().bad_extensions.default + if get_settings().config.use_extra_bad_extensions: + bad_extensions += get_settings().bad_extensions.extra + return [f for f in files if f.filename is not None and is_valid_file(f.filename, bad_extensions)] -def is_valid_file(filename: str): +def is_valid_file(filename, bad_extensions=None): + if not bad_extensions: + bad_extensions = get_settings().bad_extensions.default + if get_settings().config.use_extra_bad_extensions: + bad_extensions += get_settings().bad_extensions.extra return filename.split('.')[-1] not in bad_extensions