From 0e54a1327229fcf898522f34eef4efd3cc631404 Mon Sep 17 00:00:00 2001 From: Ori Kotek Date: Wed, 29 Nov 2023 11:52:02 +0200 Subject: [PATCH] Improve error handling in settings retrieval Fix bug where default values were not being used in GitHub Action runners when environmental variables are not set. Now, if an environmental variable cannot be found and no default is given, the default value will be used if one exists. This will prevent errors during setup on different environments and ensure system stability. --- pr_agent/servers/github_action_runner.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pr_agent/servers/github_action_runner.py b/pr_agent/servers/github_action_runner.py index 3a884407..45f9c712 100644 --- a/pr_agent/servers/github_action_runner.py +++ b/pr_agent/servers/github_action_runner.py @@ -25,7 +25,7 @@ def get_setting_or_env(key: str, default: Union[str, bool] = None) -> Union[str, try: value = get_settings().get(key, default) except AttributeError: # TBD still need to debug why this happens on GitHub Actions - value = os.getenv(key, None) or os.getenv(key.upper(), None) or os.getenv(key.lower(), None) + value = os.getenv(key, None) or os.getenv(key.upper(), None) or os.getenv(key.lower(), None) or default return value