Compare commits

...

2 Commits

Author SHA1 Message Date
f60d68af2c [pr-66] fix: make old_line and new_line optional for image diff discussions
🐛 Bug Fix:
- Image files in GitLab MR discussions use x/y coordinates instead of line numbers
- Fixed schema validation error when fetching discussions on image files

📝 Details:
- Changed old_line and new_line from required to optional in GitLabDiscussionNoteSchema
- Allows proper handling of image diff comments that use position_type: 'image'
2025-05-30 12:37:16 +09:00
3ce688b55c Merge pull request #65 from zereight/feat/ci_push_docker_hub
FEAT: ci push docker hub
2025-05-30 09:27:07 +09:00

View File

@ -618,21 +618,21 @@ export const GitLabDiscussionNoteSchema = z.object({
old_path: z.string(),
new_path: z.string(),
position_type: z.enum(["text", "image", "file"]),
old_line: z.number().nullable(),
new_line: z.number().nullable(),
old_line: z.number().nullish(), // This is missing for image diffs
new_line: z.number().nullish(), // This is missing for image diffs
line_range: z
.object({
start: z.object({
line_code: z.string(),
type: z.enum(["new", "old", "expanded"]),
old_line: z.number().nullable(),
new_line: z.number().nullable(),
old_line: z.number().nullish(), // This is missing for image diffs
new_line: z.number().nullish(), // This is missing for image diffs
}),
end: z.object({
line_code: z.string(),
type: z.enum(["new", "old", "expanded"]),
old_line: z.number().nullable(),
new_line: z.number().nullable(),
old_line: z.number().nullish(), // This is missing for image diffs
new_line: z.number().nullish(), // This is missing for image diffs
}),
})
.nullable()